Just some improvements in the code, using lamba, logging and some other stuff#1
Open
ali4j wants to merge 6 commits intoluugiathuy:masterfrom
Open
Just some improvements in the code, using lamba, logging and some other stuff#1ali4j wants to merge 6 commits intoluugiathuy:masterfrom
ali4j wants to merge 6 commits intoluugiathuy:masterfrom
Conversation
…hod (downloadResourcePartially) to use try-resource instead of try-catch-finally
removes some comments. replaces sysout with jul.
removes unused comments. replaces sysout with jul.
…le, its tested in windows, I'm gonna test it in linux tomorrow., also the destination directory is changed to the user default directory, i.e usr.dir
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There will be other improvements soon, I've planned to use NIO for downloading part.